From 290776a28694cbf018691b077d2ebf797bb628a0 Mon Sep 17 00:00:00 2001 From: DL6ER Date: Tue, 10 Aug 2021 12:13:23 +0200 Subject: [PATCH 1/2] Log if there was no detection made by the module Signed-off-by: DL6ER --- mvt/common/module.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mvt/common/module.py b/mvt/common/module.py index bf40202..9d88768 100644 --- a/mvt/common/module.py +++ b/mvt/common/module.py @@ -167,6 +167,8 @@ def run_module(module): else: try: module.check_indicators() + if not module.detected: + module.log.info("No detection!") except NotImplementedError: pass From 8d93ab66c9dffe8ca4567cf0658e8fe0b767273e Mon Sep 17 00:00:00 2001 From: Nex Date: Thu, 12 Aug 2021 12:56:12 +0200 Subject: [PATCH 2/2] Improved logging around detection results --- mvt/common/module.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mvt/common/module.py b/mvt/common/module.py index 9d88768..74ed28a 100644 --- a/mvt/common/module.py +++ b/mvt/common/module.py @@ -167,10 +167,14 @@ def run_module(module): else: try: module.check_indicators() - if not module.detected: - module.log.info("No detection!") except NotImplementedError: + module.log.info("The %s module does not support checking for indicators", + module.__class__.__name__) pass + else: + if module.indicators and not module.detected: + module.log.info("The %s module produced no detections!", + module.__class__.__name__) try: module.to_timeline()