Sorting imports and removing unused ones

mvt/ios/cmd_check_usb.py

@@ -5,8 +5,9 @@
 
 import logging
 import sys
-from pymobiledevice3.lockdown import LockdownClient
+
 from pymobiledevice3.exceptions import ConnectionFailedError
+from pymobiledevice3.lockdown import LockdownClient
 
 from mvt.common.command import Command
 

mvt/ios/modules/usb/applications.py

@@ -4,7 +4,9 @@
 #   https://license.mvt.re/1.1/
 
 import logging
-from pymobiledevice3.services.installation_proxy import InstallationProxyService
+
+from pymobiledevice3.services.installation_proxy import \
+    InstallationProxyService
 
 from .base import IOSUSBExtraction
 

mvt/ios/modules/usb/base.py

@@ -3,18 +3,9 @@
 # Use of this software is governed by the MVT License 1.1 that can be found at
 #   https://license.mvt.re/1.1/
 
-import base64
-import getpass
 import logging
-import os
-import random
-import string
-import sys
-import tempfile
-import time
-from typing import Callable
 
-from mvt.common.module import InsufficientPrivileges, MVTModule
+from mvt.common.module import MVTModule
 
 log = logging.getLogger(__name__)
 

mvt/ios/modules/usb/device_info.py

@@ -3,8 +3,8 @@
 # Use of this software is governed by the MVT License 1.1 that can be found at
 #   https://license.mvt.re/1.1/
 
-import logging
 import base64
+import logging
 
 from mvt.ios.versions import latest_ios_version
 

mvt/ios/modules/usb/processes.py

@@ -4,6 +4,7 @@
 #   https://license.mvt.re/1.1/
 
 import logging
+
 from pymobiledevice3.services.os_trace import OsTraceService
 
 from .base import IOSUSBExtraction

tests/ios_usb/test_applications.py

@@ -5,14 +5,14 @@
 
 import logging
 
+from pymobiledevice3.lockdown import LockdownClient
+
 from mvt.common.module import run_module
 from mvt.ios.modules.usb.applications import Applications
-from pymobiledevice3.lockdown import LockdownClient
 
 
 class TestUSBApplication:
     def test_run(self, mocker):
-        # Mock
         mocker.patch("pymobiledevice3.lockdown.LockdownClient.start_service")
         mocker.patch("pymobiledevice3.usbmux.select_device")
         mocker.patch("pymobiledevice3.service_connection.ServiceConnection.create")

tests/ios_usb/test_device_info.py

@@ -5,14 +5,14 @@
 
 import logging
 
+from pymobiledevice3.lockdown import LockdownClient
+
 from mvt.common.module import run_module
 from mvt.ios.modules.usb.device_info import DeviceInfo
-from pymobiledevice3.lockdown import LockdownClient
 
 
 class TestUSBDeviceInfo:
     def test_run(self, mocker):
-        # Mock
         mocker.patch("pymobiledevice3.usbmux.select_device")
         mocker.patch("pymobiledevice3.service_connection.ServiceConnection.create")
         mocker.patch(

tests/ios_usb/test_processes.py

@@ -5,21 +5,19 @@
 
 import logging
 
+from mvt.common.indicators import Indicators
 from mvt.common.module import run_module
 from mvt.ios.modules.usb.processes import Processes
-from mvt.common.indicators import Indicators
 
 
 class TestUSBProcesses:
     def test_run(self, mocker, indicator_file):
-        # Mock
         mocker.patch("pymobiledevice3.services.base_service.BaseService.__init__")
         mocker.patch(
             "pymobiledevice3.services.os_trace.OsTraceService.get_pid_list",
             return_value={"Payload": {"1": {"ProcessName": "storebookkeeperd"}, "1854": {"ProcessName": "cfprefssd"}}}
         )
 
-        # indicators
         ind = Indicators(log=logging)
         ind.parse_stix2(indicator_file)
         ind.ioc_collections[0]["processes"].append("cfprefssd")