From b2e9f0361b2797de83dba5e1098d23f70a52a9e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Donncha=20=C3=93=20Cearbhaill?=
 <donncha.ocearbhaill@amnesty.org>
Date: Fri, 7 Jan 2022 18:24:24 +0100
Subject: [PATCH] Fix repeated results due to global results[] variable

---
 tests/ios/test_datausage.py |  6 +++---
 tests/ios/test_manifest.py  |  6 +++---
 tests/ios/test_tcc.py       | 11 ++++++++++-
 3 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/tests/ios/test_datausage.py b/tests/ios/test_datausage.py
index 0ec2590..9ebf498 100644
--- a/tests/ios/test_datausage.py
+++ b/tests/ios/test_datausage.py
@@ -8,18 +8,18 @@ from ..utils import get_backup_folder
 
 class TestDatausageModule:
     def test_datausage(self):
-        m = Datausage(base_folder=get_backup_folder(), log=logging)
+        m = Datausage(base_folder=get_backup_folder(), log=logging, results=[])
         run_module(m)
         assert len(m.results) == 42
         assert len(m.timeline) == 60
         assert len(m.detected) == 0
 
     def test_detection(self, indicator_file):
-        m = Datausage(base_folder=get_backup_folder(), log=logging)
+        m = Datausage(base_folder=get_backup_folder(), log=logging, results=[])
         ind = Indicators(log=logging)
         ind.parse_stix2(indicator_file)
         # Adds a file that exists in the manifest
         ind.ioc_processes[0] = "CumulativeUsageTracker"
         m.indicators = ind
         run_module(m)
-        assert len(m.detected) == 4
+        assert len(m.detected) == 2
diff --git a/tests/ios/test_manifest.py b/tests/ios/test_manifest.py
index 20af5b2..7316a90 100644
--- a/tests/ios/test_manifest.py
+++ b/tests/ios/test_manifest.py
@@ -9,18 +9,18 @@ from ..utils import get_backup_folder
 
 class TestManifestModule:
     def test_manifest(self):
-        m = Manifest(base_folder=get_backup_folder(), log=logging)
+        m = Manifest(base_folder=get_backup_folder(), log=logging, results=[])
         run_module(m)
         assert len(m.results) == 3721
         assert len(m.timeline) == 5881
         assert len(m.detected) == 0
 
     def test_detection(self, indicator_file):
-        m = Manifest(base_folder=get_backup_folder(), log=logging)
+        m = Manifest(base_folder=get_backup_folder(), log=logging, results=[])
         ind = Indicators(log=logging)
         ind.parse_stix2(indicator_file)
         # Adds a file that exists in the manifest
         ind.ioc_files[0] = "com.apple.CoreBrightness.plist"
         m.indicators = ind
         run_module(m)
-        assert len(m.detected) == 2
+        assert len(m.detected) == 1
diff --git a/tests/ios/test_tcc.py b/tests/ios/test_tcc.py
index 4d11455..dea6faa 100644
--- a/tests/ios/test_tcc.py
+++ b/tests/ios/test_tcc.py
@@ -7,7 +7,16 @@ from ..utils import get_backup_folder
 
 class TestManifestModule:
     def test_manifest(self):
-        m = TCC(base_folder=get_backup_folder(), log=logging)
+        m = TCC(base_folder=get_backup_folder(), log=logging, results=[])
+        run_module(m)
+        assert len(m.results) == 11
+        assert len(m.timeline) == 11
+        assert len(m.detected) == 0
+        assert m.results[0]["service"] == "kTCCServiceUbiquity"
+        assert m.results[0]["auth_value"] == "allowed"
+
+    def test_manifest_2(self):
+        m = TCC(base_folder=get_backup_folder(), log=logging, results=[])
         run_module(m)
         assert len(m.results) == 11
         assert len(m.timeline) == 11