Merge 4b89887f4b into 4681b57adc

* Handle no indicators provided in `sms_attachments.py`

* Move guard to a more specific place

* Unrelated black formatting

* Related black changes :)

Dockerfile

@@ -13,7 +13,6 @@ ENV DEBIAN_FRONTEND=noninteractive
 # ----------------------------
 RUN apt update \
   && apt install -y python3 python3-pip libusb-1.0-0-dev wget unzip default-jre-headless adb \
-
 # Install build tools for libimobiledevice
 # ----------------------------------------
   build-essential \
@@ -27,7 +26,6 @@ RUN apt update \
   libssl-dev \
   sqlite3 \
   pkg-config \
-
 # Clean up
 # --------
   && apt-get clean \
@@ -41,17 +39,11 @@ RUN git clone https://github.com/libimobiledevice/libplist \
   && git clone https://github.com/libimobiledevice/libusbmuxd \
   && git clone https://github.com/libimobiledevice/libimobiledevice \
   && git clone https://github.com/libimobiledevice/usbmuxd \
-
   && cd libplist && ./autogen.sh && make && make install && ldconfig \
-
   && cd ../libimobiledevice-glue && PKG_CONFIG_PATH=/usr/local/lib/pkgconfig ./autogen.sh --prefix=/usr && make && make install && ldconfig \
-
   && cd ../libusbmuxd && PKG_CONFIG_PATH=/usr/local/lib/pkgconfig ./autogen.sh && make && make install && ldconfig \
-
   && cd ../libimobiledevice && PKG_CONFIG_PATH=/usr/local/lib/pkgconfig ./autogen.sh --enable-debug && make && make install && ldconfig \
-
   && cd ../usbmuxd && PKG_CONFIG_PATH=/usr/local/lib/pkgconfig ./autogen.sh --prefix=/usr --sysconfdir=/etc --localstatedir=/var --runstatedir=/run && make && make install \
-
   # Clean up.
   && cd .. && rm -rf libplist libimobiledevice-glue libusbmuxd libimobiledevice usbmuxd
 

mvt/ios/modules/mixed/calls.py

@@ -69,9 +69,9 @@ class Calls(IOSExtraction):
                     "isodate": convert_mactime_to_iso(row[0]),
                     "duration": row[1],
                     "location": row[2],
-                    "number": row[3].decode("utf-8")
-                    if row[3] and row[3] is bytes
-                    else row[3],
+                    "number": (
+                        row[3].decode("utf-8") if row[3] and row[3] is bytes else row[3]
+                    ),
                     "provider": row[4],
                 }
             )

mvt/ios/modules/mixed/sms_attachments.py

@@ -56,7 +56,9 @@ class SMSAttachments(IOSExtraction):
     def check_indicators(self) -> None:
         for attachment in self.results:
             # Check for known malicious filenames.
-            if self.indicators.check_file_path(attachment["filename"]):
+            if self.indicators and self.indicators.check_file_path(
+                attachment["filename"]
+            ):
                 self.detected.append(attachment)
 
             if (