Download checks #3

Closed
depsterr wants to merge 2 commits from master into master
depsterr commented 2020-02-06 17:18:13 +00:00 (Migrated from github.com)

Download checks

The script now checks for the targeted file in the current directory before downloading it. This is to prevent re-downloading the same files if the script was aborted. It does this by checking if the targeted download file is already present in the directory before downloading.

ls "${UBOOT_JOB}.zip" || {
    # Downloads ${UBOOT_JOB}.zip
}
ls "${ROOTFS_JOB}.zip" || {
    # Download ${ROOTF_JOB}.zip
}
# Download checks The script now checks for the targeted file in the current directory before downloading it. This is to prevent re-downloading the same files if the script was aborted. It does this by checking if the targeted download file is already present in the directory before downloading. ```bash ls "${UBOOT_JOB}.zip" || { # Downloads ${UBOOT_JOB}.zip } ``` ```bash ls "${ROOTFS_JOB}.zip" || { # Download ${ROOTF_JOB}.zip }
Kokokokoka commented 2020-02-08 15:21:30 +00:00 (Migrated from github.com)

There must be a check that the file on disk is sane.

There must be a check that the file on disk is sane.
Kokokokoka commented 2020-02-08 19:59:09 +00:00 (Migrated from github.com)

Also, there is if [ -f filename ]; or test for this. no need for ls whatsoever.

Also, there is if [ -f filename ]; or test for this. no need for ls whatsoever.
DylanVanAssche commented 2020-02-09 17:57:57 +00:00 (Migrated from github.com)

If a new version of the file is available, the user must get the latest version from the CI.
That's the reason why I didn't add this feature in the initial version.

If a new version of the file is available, the user must get the latest version from the CI. That's the reason why I didn't add this feature in the initial version.
Kokokokoka commented 2020-02-09 21:30:50 +00:00 (Migrated from github.com)

is there any hash? One can compare the hash beforehand and then download new build if needed.

is there any hash? One can compare the hash beforehand and then download new build if needed.

Pull request closed

Sign in to join this conversation.
No description provided.